refactor(gui): remove dead color_approx flag and unreachable warning#20007
Closed
h-east wants to merge 1 commit intovim:masterfrom
Closed
refactor(gui): remove dead color_approx flag and unreachable warning#20007h-east wants to merge 1 commit intovim:masterfrom
h-east wants to merge 1 commit intovim:masterfrom
Conversation
Problem:
gui.color_approx in gui_T has not been assigned anywhere since patch
7.4.2094 ("The color allocation in X11 is overly complicated", 2016),
which dropped the single "gui.color_approx = TRUE;" site. Because the
member is zero-initialized and never written, the check
"if (gui.color_approx)" in gui_mch_init() is always false and the
"E458: Cannot allocate colormap entry, ..." warning can never be
emitted.
Solution:
Remove the struct member and the unreachable branch. The E458 error
definition is removed but a "// E458 unused" marker is left in place
so the number is not reused by future changes. Update the example
error code "E458" in the ex_eval.c comment to "E457" accordingly.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
gui.color_approx in gui_T has not been assigned anywhere since patch 7.4.2094 ("The color allocation in X11 is overly complicated", 2016), which dropped the single "gui.color_approx = TRUE;" site. Because the member is zero-initialized and never written, the check "if (gui.color_approx)" in gui_mch_init() is always false and the "E458: Cannot allocate colormap entry, ..." warning can never be emitted.
Solution:
Remove the struct member and the unreachable branch. The E458 error definition is removed but a "// E458 unused" marker is left in place so the number is not reused by future changes. Update the example error code "E458" in the ex_eval.c comment to "E457" accordingly.