ROX-33962: Remove Orchestrator Components from Global Search#20078
Merged
ROX-33962: Remove Orchestrator Components from Global Search#20078
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
cfc1094 to
a11851b
Compare
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Now that the global search flow no longer uses
ORCHESTRATOR_COMPONENTS_KEYor auto-injects theOrchestrator Componentfilter, consider cleaning up any remaining references/constants and UI elements tied specifically to that toggle so the codebase doesn’t retain dead or misleading configuration.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Now that the global search flow no longer uses `ORCHESTRATOR_COMPONENTS_KEY` or auto-injects the `Orchestrator Component` filter, consider cleaning up any remaining references/constants and UI elements tied specifically to that toggle so the codebase doesn’t retain dead or misleading configuration.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20078 +/- ##
=======================================
Coverage 49.69% 49.69%
=======================================
Files 2766 2766
Lines 209175 209184 +9
=======================================
+ Hits 103951 103959 +8
- Misses 97536 97538 +2
+ Partials 7688 7687 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
🚀 Build Images ReadyImages are ready for commit a11851b. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-690-ga11851b2d1 |
pedrottimark
approved these changes
Apr 17, 2026
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As titled, this functionality has been replaced with "Platform Components" which can be used natively from the search bar.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Orchestrator Components toggle is no longer present on global search page:
Search queries do not include "Orchestrator Components"
Platform Components is available and functional in the search filter bar:
