fix(landing): render proper 404 for invalid /models and /integrations routes#4232
fix(landing): render proper 404 for invalid /models and /integrations routes#4232waleedlatif1 merged 1 commit intostagingfrom
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview The new Reviewed by Cursor Bugbot for commit 8ad41a2. Configure here. |
Greptile SummaryThis PR adds scoped Confidence Score: 5/5Safe to merge — minimal, focused fix with no logic issues or regressions Both new files are pure server components with no state, no data-fetching, and no side effects. The CSS variables used by AUTH_PRIMARY_CTA_BASE are globally defined in globals.css so they resolve correctly inside the landing layout context. Next.js correctly bubbles notFound() to the nearest not-found.tsx boundary, so the scoped files will intercept all invalid slug requests for their respective sections. No P1 or P0 issues found. No files require special attention Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Next as Next.js Router
participant Page as [slug]/page.tsx<br/>(dynamicParams=false)
participant ScopedNF as integrations/not-found.tsx<br/>(NEW)
participant Layout as IntegrationsLayout<br/>(Navbar + Footer)
participant RootNF as app/not-found.tsx<br/>(BEFORE — duplicate Navbar)
User->>Next: GET /integrations/rand
Next->>Page: render page
Page-->>Next: notFound() thrown
Note over Next,RootNF: BEFORE this PR
Next->>RootNF: bubble to root not-found
RootNF->>Layout: layout wraps → duplicate Navbar crash
Note over Next,ScopedNF: AFTER this PR
Next->>ScopedNF: caught by nearest not-found.tsx
Layout->>ScopedNF: wraps with Navbar + Footer (correct)
ScopedNF-->>User: styled 404 with single Navbar
Reviews (2): Last reviewed commit: "fix(landing): render proper 404 for inva..." | Re-trigger Greptile |
b3e9bf0 to
8ad41a2
Compare
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8ad41a2. Configure here.

Summary
not-found.tsxfor/modelsand/integrationsso invalid slugs (e.g./models/anthropic/123,/integrations/rand) render the styled 404 instead of crashing with "Application error: a client-side exception has occurred"page.tsxusedynamicParams = falseand callnotFound(), which fell back toapp/not-found.tsx. That file renders its own<Navbar>+<AuthBackground fixed inset-0>on top of the section layout's<Navbar>+<Footer>, duplicating client hooks and conflicting positioningType of Change
Testing
Tested manually — visiting
/models/anthropic/123,/models/not-a-real-provider, and/integrations/randnow renders the styled 404. Valid URLs still render normally; root 404 behavior unchanged.Checklist