Added 'refList' as a list containing all referrals returned from server.#459
Open
nickfolino wants to merge 1 commit intopython-ldap:mainfrom
Open
Added 'refList' as a list containing all referrals returned from server.#459nickfolino wants to merge 1 commit intopython-ldap:mainfrom
nickfolino wants to merge 1 commit intopython-ldap:mainfrom
Conversation
tiran
requested changes
Feb 1, 2022
Member
tiran
left a comment
There was a problem hiding this comment.
Every Python API call requires an explicit error check.
Please also include documentation update and test cases.
|
|
||
| if (errnum == LDAP_REFERRAL && refs != NULL && refs[0] != NULL) { | ||
| /* Return all referrals as a list in "reflist" */ | ||
| PyObject *referralList = PyList_New(0); |
| PyObject *referralList = PyList_New(0); | ||
| int i = 0; | ||
| while (refs[i] != NULL) { | ||
| PyObject *referralURL = Py_BuildValue("s", refs[i++]); |
Member
There was a problem hiding this comment.
Use PyUnicode_FromString() and check for error (NULL).
| int i = 0; | ||
| while (refs[i] != NULL) { | ||
| PyObject *referralURL = Py_BuildValue("s", refs[i++]); | ||
| PyList_Append(referralList, referralURL); |
| PyList_Append(referralList, referralURL); | ||
| Py_XDECREF(referralURL); | ||
| } | ||
| PyDict_SetItemString(info, "reflist", referralList); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a refList that contains all referrals returned from the server.
Still maintains the first referral in 'info'.