Fix a significant error (causes a hang) in PR 16208.#16371
Closed
Coises wants to merge 1 commit intonotepad-plus-plus:masterfrom
Closed
Fix a significant error (causes a hang) in PR 16208.#16371Coises wants to merge 1 commit intonotepad-plus-plus:masterfrom
Coises wants to merge 1 commit intonotepad-plus-plus:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix applied in PR #16208 to avoid a hang when using certain regular expressions with certain data resolved that issue but created a new one. Prior to PR #16208, when called (after a zero-length match at the end of the document) with the length of the document as argument, BoostRegexSearch::SearchParameters::nextCharacter returned one greater than the length of the document. PR #16208 did not account for that, and it fails to advance the match position after a zero-length match at the end of the document, thus causing an infinite loop. This change fixes that by assuring that when BoostRegexSearch::SearchParameters::nextCharacter is called, the return is always at least one greater than the argument. This will avoid the end-of-document failure while preserving the correct behavior in the cases PR #16208 fixed.