fix: check return code in unpack_callback_int64#665
Open
KowalskiThomas wants to merge 1 commit intomsgpack:mainfrom
Open
fix: check return code in unpack_callback_int64#665KowalskiThomas wants to merge 1 commit intomsgpack:mainfrom
unpack_callback_int64#665KowalskiThomas wants to merge 1 commit intomsgpack:mainfrom
Conversation
| if (d > LONG_MAX) { | ||
| p = PyLong_FromUnsignedLongLong((unsigned PY_LONG_LONG)d); | ||
| } else { | ||
| p = PyLong_FromLong((long)d); |
Contributor
There was a problem hiding this comment.
Should this be PyLong_FromUnsignedLong((unsigned long)d)?
Member
There was a problem hiding this comment.
Both are correct. Since we checked d <= LONG_MAX, (long)d is guaranteed to fit in a signed long.
But p = PyLong_FromUnsignedLongLong((unsigned PY_LONG_LONG)d) without d > LONG_MAX check would be better.
| static inline int unpack_callback_int64(unpack_user* u, int64_t d, msgpack_unpack_object* o) | ||
| { | ||
| PyObject *p; | ||
| if (d > LONG_MAX || d < LONG_MIN) { |
Contributor
There was a problem hiding this comment.
That "|| d < LONG_MIN" looks strange, is it correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simply adds a null pointer check after calling
PyLong_FromLongLong/PyLong_FromLonglike other similar functions do it (example here).