Move libgit.a sources into separat "lib/" directory #2271
Open
pks-gitlab wants to merge 3 commits intogit:masterfrom
Open
Move libgit.a sources into separat "lib/" directory #2271pks-gitlab wants to merge 3 commits intogit:masterfrom
pks-gitlab wants to merge 3 commits intogit:masterfrom
Conversation
Hi,
this small patch series follows up on a discussion we had two years ago
during the Git Contributor's Summit in Berlin.
I'm fully aware that this will likely result in some discussion, which
is why I have labelled this as RFC. I'd be fine with a result of "let's
not do it" if we cannot agree on this step, but I think that the current
layout hurts discoverability quite a bit. Not only for newcomers, but
I'm also struggling with it quite frequently.
I also intentionally decided to send this close to the upcoming release
so that the series can be merged early in the next release cycle if we
were to agree on it.
Thanks!
Patrick
To: git@vger.kernel.org
--- b4-submit-tracking ---
# This section is used internally by b4 prep for tracking purposes.
{
"series": {
"revision": 1,
"change-id": "20260415-pks-libgit-in-subdir-d8eec849cd48",
"prefixes": [
"RFC"
],
"presubject": ""
}
}
|
There is an issue in commit a1057aa:
|
|
There is an issue in commit eadf54f:
|
|
There is an issue in commit 6c0c3ab:
|
6c0c3ab to
81d8e54
Compare
In the next commit we're about to introduce a new "lib/" directory and move all of our files into it. With this split the compiler won't be able to find one of the includes in "test-example-tap.c" anymore. Adjust it to a relative include to prepare for this change. Signed-off-by: Patrick Steinhardt <ps@pks.im>
81d8e54 to
a3364aa
Compare
|
There is an issue in commit a1057aa:
|
1 similar comment
|
There is an issue in commit a1057aa:
|
a3364aa to
2533db0
Compare
|
There is an issue in commit a1057aa:
|
The Git project is not exactly the easiest project to get started in: it's written in C and POSIX shell, with bits of Perl, Rust and other languages sprinkled into it. On top of that, the project has grown somewhat organically over time, making the codebase hard to navigate. These are problems that we're aware of, and there have been and still are efforts to clean up some of the technical debt that is natural to exist an a project that is more than 20 years old. Furthermore, we provide resources to newcomers that help them out like our coding guidelines, code of conduct or "MyFirstContribution.adoc". But there is a rather practical problem: finding your way around in our project's tree is not easy. Doing a directory listing in the top-level directory will present you with more than 550 files, which makes it extremely hard for a newcomer to figure out what files they are even supposed to look at. This makes the onboarding experience somewhat harder than it really needs to be. This isn't only a problem for newcomers though, as I myself struggle to find the files I am looking for because of the sheer number of files. Besides the problem of discoverability it also creates a problem of structure. It is not obvious at all which files are part of "libgit.a" and which files are only linked into our final executables. So while we have this split in our build systems, that split is not evident at all in our tree. Introduce a new "lib/" directory and move all of our sources for "libgit.a" into it to fix these issues. It makes the split we have evident and reduces the number of files in our top-level tree from 550 files to ~80 files. This is still a lot of files, but it's significantly easier to navigate already. Furthermore, we can further iterate after this step and think about introducing a better structure for remaining files, as well. Signed-off-by: Patrick Steinhardt <ps@pks.im>
2533db0 to
aaf4dd6
Compare
|
There is an issue in commit a1057aa:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR verifies that CI is succeeding with those changes.