fix(site): sync rename dialog state in template editor#24501
Draft
fix(site): sync rename dialog state in template editor#24501
Conversation
The RenameFileDialog is always mounted (MUI Dialog does not unmount children when closed), so useState(filename) only captures the initial value on first mount. Because the dialog initially mounts with an empty filename, every subsequent open showed a stale empty input rather than the current file path. Track the previous filename prop and reset pathValue during render when it changes, following the React 'adjusting state during render' pattern instead of useEffect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rename dialog in the template files editor never showed the current filename in the input field.
RenameFileDialogstays mounted for the lifetime of the editor, souseState(filename)only captured the initial empty value and never updated when a different file was selected for renaming.Track the previous
filenameprop and resetpathValueduring render when it changes.Note
Generated by Coder Agents