Closed
Conversation
10 tasks
nyamatongwe
pushed a commit
that referenced
this pull request
Aug 4, 2022
Member
|
Committed the 7eaf635 change set with examples in x.jl as 84f9a6c. Pull requests should include short test cases that show 'bad before; good after' so they can be checked and will remain fixed. The above example doesn't parse as stated since Lexing result both before and after e267314 However, it does fix the originating problem and this simplified example: table[d]!='#' for d=[(1,0),(-1,0),(0,1),(0,-1)] |
Contributor
Author
|
Sorry, I put a bad example (I edited the first message). I added a commit with a test case. |
nyamatongwe
pushed a commit
that referenced
this pull request
Aug 6, 2022
Test apostrophe after exclamation.
Member
|
Committed. |
Closed
Member
|
Included in 5.1.9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #97
EDIT: now a correct "bad before; good after" example.
is now parsed correctly as
tableidentifier,[]brackets,!=operator and'#'character.Instead of
tableidentifier,[]brackets,!='operator and#'comment (because the first'was incorrectly parsed as adjoint)Also update unicode characters allowed as identifiers.