Matlab class syntax improvement#75
Closed
oswald3141 wants to merge 1 commit intoScintillaOrg:masterfrom
Closed
Conversation
Add handling of the following contextual keywords, used in classes' declarations: properties, methods, events.
nyamatongwe
pushed a commit
that referenced
this pull request
Apr 22, 2022
Add handling of the following contextual keywords, used in classes' declarations: properties, methods, events.
Member
|
Committed as 17c58fd with addition to change log and mention of pull number in commit message. |
Contributor
Author
|
Thank you! |
Member
|
Included in 5.1.7 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zufuliu suggested adding support for the classes definition syntax in the discussion of PR #70. This PR contains a proposed solution.
It works fine with the correct syntax but employs a little hack: it doesn't recognize function scopes to avoid storing too much data in the line state integer. Instead, it just considers everything within a folding level beyond the 2nd to be a function's scope. This consideration may lead to the erroneous neglect of some keywords (there's an example in the proposed test). However, such a problem can occur only in a file with invalid syntax, so I think it's not really an issue.