Skip to content

zig: Support identifiers expressed as strings#287

Closed
techee wants to merge 2 commits intoScintillaOrg:masterfrom
techee:zig_identifier_string
Closed

zig: Support identifiers expressed as strings#287
techee wants to merge 2 commits intoScintillaOrg:masterfrom
techee:zig_identifier_string

Conversation

@techee
Copy link
Copy Markdown
Contributor

@techee techee commented Nov 3, 2024

@zufuliu
Copy link
Copy Markdown
Contributor

zufuliu commented Nov 3, 2024

else if (sc.state != SCE_ZIG_CHARACTER) block can be removed since format specifier highlighting is dropped.
https://ziglang.org/documentation/master/std/#std.fmt.format

example for escape sequences (similar to backticks in R), https://godbolt.org/z/nq8Kc5YhY

const @"identifier\t" = 0xff;
export fn foo(@"id\"": i32) i32 {
    return @"id\"" * @"identifier\t";
}

This is a leftover from porting the lexer from Notepad4  which contains
format specifier highlighting which has been dropped for Scintilla.
@techee
Copy link
Copy Markdown
Contributor Author

techee commented Nov 3, 2024

@zufuliu Thanks for noticing, done.

@nyamatongwe nyamatongwe added the zig Caused by the Zig lexer label Nov 4, 2024
@nyamatongwe nyamatongwe added the committed Issue fixed in repository but not in release label Nov 5, 2024
techee added a commit to techee/geany that referenced this pull request Nov 7, 2024
@techee
Copy link
Copy Markdown
Contributor Author

techee commented Nov 12, 2024

@nyamatongwe Just a note - I want to provide support for the lexers I added so if there are any problems with them in the future, just ping me (@techee). I normally don't follow the activity of the lexilla repository so I might miss it otherwise.

@nyamatongwe nyamatongwe removed the committed Issue fixed in repository but not in release label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

zig Caused by the Zig lexer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants