Skip to content

Some keyboard accelerators in Incremental Search don't work #14503

@alankilborn

Description

@alankilborn

Steps to Reproduce the Issue

  1. Create some text tttttt in a new Notepad++ tab
  2. Invoke Incremental Search with Ctrl+Alt+i
  3. Enter t in the Find edit box; observe that one of the t in the edit zone is selected
  4. Press Find Next keyboard shortcut (F3) (or Find Previous keyboard shortcut (Shift+F3))

Expected Behavior

The next (or previous) occurrence of t should be selected.

Actual Behavior

F3 (or Shift+F3) does nothing.

Analysis

The Incremental Search accelerator table is created here:

_hIncFindAccTab = ::CreateAcceleratorTable(tmpIncrFindAccelArray, static_cast<int32_t>(nb));

and is soon after and wrongly deleted here:
if (_hIncFindAccTab)
::DestroyAcceleratorTable(_hIncFindAccTab);

Debug Information

Notepad++ v8.6 (64-bit)
Build time : Nov 23 2023 - 16:58:44
Path : C:\NotepadPlusPlus\Misc_NoBackup\Releases\npp.8.6\npp.8.6.portable.x64\notepad++.exe
Command Line : -titleAdd="8.6 64-bit" -multiInst
Admin mode : OFF
Local Conf mode : ON
Cloud Config : OFF
OS Name : Windows 11 Pro (64-bit)
OS Version : 22H2
OS Build : 22621.2715
Current ANSI codepage : 1252
Plugins :
mimeTools (2.9)
NppConverter (4.5)
NppExport (0.4)
PythonScript (3.0.16)

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions